Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Fixes #2371.

#2371 seems to already be handled correctly in the lint. This PR adds a ui regression test so we can close it.

r? @blyxyas

changelog: Add regression ui test for #2371

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 29, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Jan 29, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 29, 2024

📌 Commit ce8b4b6 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 29, 2024

⌛ Testing commit ce8b4b6 with merge c148bce...

bors added a commit that referenced this pull request Jan 29, 2024
…xyas

Add regression ui test for #2371

Fixes #2371.

#2371 seems to already be handled correctly in the lint. This PR adds a ui regression test so we can close it.

r? `@blyxyas`

changelog: Add regression ui test for #2371
@bors
Copy link
Contributor

bors commented Jan 29, 2024

💔 Test failed - checks-action_test

@GuillaumeGomez
Copy link
Member Author

I think it's a flaky failure.

@blyxyas
Copy link
Member

blyxyas commented Jan 29, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 29, 2024

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Jan 29, 2024

📌 Commit ce8b4b6 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 29, 2024

⌛ Testing commit ce8b4b6 with merge 455c07b...

@bors
Copy link
Contributor

bors commented Jan 29, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 455c07b to master...

@bors bors merged commit 455c07b into rust-lang:master Jan 29, 2024
@GuillaumeGomez GuillaumeGomez deleted the add-regression-test-2371 branch January 30, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't suggest eta-reducible replacements in UNNECESSARY_FOLD lint
4 participants